netdev - Re: [PATCH net-2.6.25 (v2)] [TCP]: Two fixes to new sacktag code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071129140053.GA9145@gondor.apana.org.au>
Date:	Fri, 30 Nov 2007 01:00:53 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	Netdev <netdev@...r.kernel.org>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-2.6.25 (v2)] [TCP]: Two fixes to new sacktag code

On Wed, Nov 28, 2007 at 06:52:51PM +0200, Ilpo Järvinen wrote:
> On Wed, 28 Nov 2007, Ilpo Järvinen wrote:
> 
> > @@ -1575,7 +1575,7 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff *ack_skb, u32 prior_snd_
> >  			continue;
> >  		}
> >
> > -		if (!before(start_seq, tcp_highest_sack_seq(tp))) {
> > +		if (tp->sacked_out && after(start_seq, tcp_highest_sack_seq(tp))) {
> 
> In this v2, of this patch I'll put !before back here instead, change
> to after is unnecessary here, checking that a sacked skb exists is
> enough to avoid skipping in the problematic head case.

Thanks Ilpo, patch applied to net-2.6.25.

BTW, how's the RB-tree stuff coming along? David wanted it to be in as
early as possible so that it gets the maximum amount of testing before
the next merge window.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html