netdev - Re: [PATCH] e1000: Fix NAPI state bug when Rx complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4751D367.3030908@garzik.org>
Date:	Sat, 01 Dec 2007 16:34:31 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, Robert.Olsson@...a.slu.se,
	shemminger@...ux-foundation.org, davem@...emloft.net
Subject: Re: [PATCH] e1000: Fix NAPI state bug when Rx complete

Auke Kok wrote:
> Don't exit polling when we have not yet used our budget, this causes
> the NAPI system to end up with a messed up poll list.
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> ---
> 
>  drivers/net/e1000/e1000_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> index b7c3070..724f067 100644
> --- a/drivers/net/e1000/e1000_main.c
> +++ b/drivers/net/e1000/e1000_main.c
> @@ -3926,7 +3926,7 @@ e1000_clean(struct napi_struct *napi, int budget)
>  	                  &work_done, budget);
>  
>  	/* If no Tx and not enough Rx work done, exit the polling mode */
> -	if ((!tx_cleaned && (work_done < budget)) ||
> +	if ((!tx_cleaned && (work_done == 0)) ||
>  	   !netif_running(poll_dev)) {

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html