netdev - Re: [PATCH 13/21] [TCP]: Store retransmit queue packets in RB tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712021133250.4539@kivilampi-30.cs.helsinki.fi>
Date:	Sun, 2 Dec 2007 13:20:38 +0200 (EET)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Herbert Xu <herbert@...dor.apana.org.au>
cc:	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [PATCH 13/21] [TCP]: Store retransmit queue packets in RB tree.

On Sun, 2 Dec 2007, Herbert Xu wrote:

> On Sun, Dec 02, 2007 at 12:48:08AM +0200, Ilpo Järvinen wrote:
> > 
> > This work was mostly done by David S. Miller.
> 
> ...
> 
> > @@ -253,6 +254,8 @@ struct sk_buff {
> >  	struct sk_buff		*next;
> >  	struct sk_buff		*prev;
> > 
> > +	struct rb_node		rb;
> 
> Did David really do this? :)

...Believe it or not, yes he did :-), and there's even a more convicing 
proof about that in here:

http://marc.info/?l=linux-netdev&m=117269223013422&w=2

...and in Dave's obsolete tcp-2.6 tree (which has the bug fixed 
version)... ;-)

...I changed it by just by moving tp->write_queue_rb = RB_ROOT to another 
function because I needed more initialization later on.

> I suppose if we moved this into cb (by growing it by the required amount)
> then at least the new space can be used by others.

...yeah, will do.


-- 
 i.