netdev - Re: [PATCH 12/21] [TCP]: Introduce per skb fack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071202113628.GA20942@gondor.apana.org.au>
Date:	Sun, 2 Dec 2007 22:36:28 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [PATCH 12/21] [TCP]: Introduce per skb fack_counts to retransmit queue

On Sun, Dec 02, 2007 at 01:29:36PM +0200, Ilpo Järvinen wrote:
>
> Hmm didn't crash for me, probably a silent corruption instead :-(.

It crashed during NIS start-up and I suppose I'm the only still
running NIS :)

> Maybe I could add catch for invalid skb dereferences (those list heads) to
> TCP_SKB_CB and tcp_skb_pcount if some DEBUG thing is set. Those two should
> catch at least 98% of the invalid users.
> 
> ...Not sure if CONFIG_DEBUG_LIST is right one to use, suggestion welcome.

Sounds OK to me.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html