netdev - Re: sock_valbool_flag is required by VMware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071202135851.GA1164@infradead.org>
Date:	Sun, 2 Dec 2007 13:58:51 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Pavel Emelyanov <xemul@...nvz.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: sock_valbool_flag is required by VMware

On Fri, Nov 30, 2007 at 10:52:22PM +0100, Jiri Slaby wrote:
> Hi,
> 
> this commit:
>     [NET]: Move sock_valbool_flag to socket.c
> 
>     The sock_valbool_flag() helper is used in setsockopt to
>     set or reset some flag on the sock. This helper is required
>     in the net/socket.c only, so move it there.
> 
>     Besides, patch two places in sys_setsockopt() that repeat
>     this helper functionality manually.
> 
>     Since this is not a bugfix, but a trivial cleanup, I
>     prepared this patch against net-2.6.25, but it also
>     applies (with a single offset) to the latest net-2.6.
> 
> breaks vmware module compilation, since it uses sock_valbool_flag(). Is this
> their business (and they should use sock_set_flag/sock_reset_flag) or should
> this be reverted?

It's their business, they should never have used it.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html