netdev - [PATCH net-2.6.25] TCP: Fix copy-paste (or code move) error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712021841050.11818@kivilampi-30.cs.helsinki.fi>
Date:	Sun, 2 Dec 2007 18:45:44 +0200 (EET)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Herbert Xu <herbert@...dor.apana.org.au>
cc:	David Miller <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>
Subject: [PATCH net-2.6.25] TCP: Fix copy-paste (or code move) error

Should get the skb from the same queue. I had it first elsewhere
and missed this change while moving.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
---

diff --git a/include/net/tcp.h b/include/net/tcp.h
index 7ae72c3..5929022 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1524,7 +1524,7 @@ static inline void tcp_reset_fack_counts(struct sock *sk, struct sk_buff *inskb)
 		/* Lazy find for the other queue */
 		if (skb[queue] == NULL) {
 			skb[queue] = tcp_write_queue_find(sk, TCP_SKB_CB(prev)->seq,
-						          queue ^ TCP_WQ_SACKED);
+						          queue);
 			if (skb[queue] == NULL)
 				break;
 		}
--
1.5.0.6