netdev - Re: [PATCH] sungem: fix napi regression with reset work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1196674162.6060.8.camel@johannes.berg>
Date:	Mon, 03 Dec 2007 10:29:22 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH] sungem: fix napi regression with reset work


On Thu, 2007-11-29 at 21:57 +1100, Herbert Xu wrote:
> On Mon, Nov 26, 2007 at 09:02:08PM +0100, Johannes Berg wrote:
> > sungem's gem_reset_task() will unconditionally try to disable NAPI even
> > when it's called while the interface is not operating and hence the NAPI
> > struct isn't enabled. Make napi_disable() depend on gp->running.
> > 
> > Also removes a superfluous test of gp->running in the same function.
> > 
> > Signed-off-by: Johannes Berg <johannes@...solutions.net>
> 
> Patch applied to net-2.6.  Thanks Johannes!

Thanks. I just noticed that I made a mistake in the patch description,
it should read "Make napi_disable() depend on gp->opened". I don't think
it matters much but wanted to at least mention it.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)