netdev - Re: [PATCH 2.6.25] net: removes unnecessary dependencies for net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4753F204.2010900@sw.ru>
Date:	Mon, 03 Dec 2007 15:09:40 +0300
From:	"Denis V. Lunev" <den@...ru>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	"Denis V. Lunev" <den@...nvz.org>, herbert@...dor.apana.org.au,
	devel@...nvz.org, netdev@...r.kernel.org, davem@...emloft.net,
	xemul@...nvz.org
Subject: Re: [PATCH 2.6.25] net: removes unnecessary dependencies for net_namespace.h

you right, how about this?

Eric W. Biederman wrote:
> "Denis V. Lunev" <den@...nvz.org> writes:
> 
>> This patch removes some unneeded includes for net_namespace.h to speed up
>> compilation.
>>
>> Signed-off-by: Denis V. Lunev <den@...nvz.org>
>>
>> diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
>> index f285de6..28b7f25 100644
>> --- a/include/net/pkt_cls.h
>> +++ b/include/net/pkt_cls.h
>> @@ -2,7 +2,6 @@
>>  #define __NET_PKT_CLS_H
>>  
>>  #include <linux/pkt_cls.h>
>> -#include <net/net_namespace.h>
>>  #include <net/sch_generic.h>
>>  #include <net/act_api.h>
> 
> What of tcf_match_indev?  I guess linux/netdevice.h brings
> it in for us but still.
> 
>> diff --git a/include/net/sock.h b/include/net/sock.h
>> index 43e3cd9..a04e361 100644
>> --- a/include/net/sock.h
>> +++ b/include/net/sock.h
>> @@ -57,7 +57,6 @@
>>  #include <asm/atomic.h>
>>  #include <net/dst.h>
>>  #include <net/checksum.h>
>> -#include <net/net_namespace.h>
>>  
>>  /*
>>   * This structure really needs to be cleaned up.
>> @@ -95,6 +94,7 @@ typedef struct {
>>  
>>  struct sock;
>>  struct proto;
>> +struct net;
>>  
>>  /**
>>   *	struct sock_common - minimal network layer representation of sockets
> 
> This hunk definitely looks sane.
> 
> Eric
> 
> 


View attachment "1.diff" of type "text/plain" (1028 bytes)