netdev - Re: [PATCH] Stop phy code from returning success to unknown ioctls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8D34458A-2CE9-4FA7-AE28-4D148E08CCDF@freescale.com>
Date:	Tue, 4 Dec 2007 14:00:42 -0600
From:	Andy Fleming <afleming@...escale.com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	jgarzik@...ox.com, linuxppc-dev@...abs.org,
	Domen Puncer <domen.puncer@...argo.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Stop phy code from returning success to unknown ioctls.


On Nov 28, 2007, at 13:56, David Woodhouse wrote:

> This kind of sucks, and prevents the Fedora installer from using the
> device for network installs...
>
> [root@...ka phy]# iwconfig eth0
> Warning: Driver for device eth0 has been compiled with an ancient  
> version
> of Wireless Extension, while this program support version 11 and  
> later.
> Some things may be broken...
>
> eth0        ESSID:off/any  Nickname:""
>           NWID:0  Channel:0  Access Point: 00:00:BF:81:14:E0
>           Bit Rate:-1.08206e+06 kb/s   Sensitivity=0/0
>           RTS thr:off   Fragment thr:off
>           Encryption key:<too big>
>           Power Management:off
>
> Signed-off-by: David Woodhouse <dwmw2@...radead.org>

d'oh!

Acked-by: Andy Fleming <afleming@...escale.com>


>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 9bc1177..7c9e6e3 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -406,6 +406,9 @@ int phy_mii_ioctl(struct phy_device *phydev,
>  				&& phydev->drv->config_init)
>  			phydev->drv->config_init(phydev);
>  		break;
> +
> +	default:
> +		return -ENOTTY;
>  	}
>
>  	return 0;
>
> -- 
> dwmw2
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html