netdev - Re: [PATCH] gianfar driver: eliminate compiler warnings and unnecessary macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4755B54C.60504@pobox.com>
Date:	Tue, 04 Dec 2007 15:15:08 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Grant Likely <grant.likely@...retlab.ca>
CC:	linuxppc-dev@...abs.org, netdev@...r.kernel.org,
	galak@...nel.crashing.org, afleming@...escale.com
Subject: Re: [PATCH] gianfar driver: eliminate compiler warnings and unnecessary
 macros

Grant Likely wrote:
> From: Grant Likely <grant.likely@...retlab.ca>
> 
> This patch eliminates the warning of unused return values when the driver
> registers it sysfs files.  Now the driver will print an error if it is
> unable to register the sysfs files.
> 
> It also eliminates the macros used to wrap the DEVICE_ATTR macro and the
> device_create_file function call.  The macros don't reduce the number of
> lines of source code in the file and the name munging makes is so that
> cscope and friends don't see the references to the functions.  It's better
> to just call the kernel API directly.
> 
> While we're at it, the DEVICE_ATTR instances have been moved down to
> be grouped with the functions they depend on.
> 
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> ---
> 
>  drivers/net/gianfar_sysfs.c |   50 ++++++++++++++++++++++---------------------
>  1 files changed, 25 insertions(+), 25 deletions(-)

applied #upstream


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html