netdev - Re: [PATCH][IPv6][IPsec] fix the address family for xfrm_state_lookup in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Dec 2007 22:54:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kazunori@...azawa.org
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org,
	usagi-core@...ux-ipv6.org
Subject: Re: [PATCH][IPv6][IPsec] fix the address family for
 xfrm_state_lookup in xfrm_input

From: Kazunori MIYAZAWA <kazunori@...azawa.org>
Date: Tue, 04 Dec 2007 15:23:01 +0900

> Herbert Xu wrote:
> > I'd prefer to put this in XFRM_SPI_SKB_CB instead because the xfrm
> > layer shouldn't really rely on dst->ops structures except on entry
> > and exit, like this:
> > 
> > [IPSEC]: Use the correct family for input state lookup
> > 
> > When merging the input paths of IPsec I accidentally left a hard-coded
> > AF_INET for the state lookup call.  This broke IPv6 obviously.  This
> > patch fixes by getting the input callers to specify the family through
> > skb->cb.
> > 
> > Credit goes to Kazunori Miyazawa for diagnosing this and providing an
> > initial patch.
> > 
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> > 
> > Cheers,
> 
> It works fine.

Patch applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html