netdev - Re: [PATCH][IPVS] Fix sched registration race when checking for name collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071204.004525.246971804.davem@davemloft.net>
Date:	Tue, 04 Dec 2007 00:45:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	xemul@...nvz.org, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org, devel@...nvz.org, wensong@...ux-vs.org,
	ja@....bg
Subject: Re: [PATCH][IPVS] Fix sched registration race when checking for
 name collision

From: Simon Horman <horms@...ge.net.au>
Date: Tue, 4 Dec 2007 10:41:43 +0900

> On Mon, Dec 03, 2007 at 01:10:57PM +0300, Pavel Emelyanov wrote:
> > The register_ip_vs_scheduler() checks for the scheduler with the
> > same name under the read-locked __ip_vs_sched_lock, then drops,
> > takes it for writing and puts the scheduler in list.
> > 
> > This is racy, since we can have a race window between the lock
> > being re-locked for writing.
> > 
> > The fix is to search the scheduler with the given name right under
> > the write-locked __ip_vs_sched_lock.
> 
> This looks correct to me.
> 
> > Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
> 
> Acked-by: Simon Horman <horms@...ge.net.au>

Also applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html