netdev - Re: [NETLINK]: af_netlink.c checkpatch cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1196788863.4898.13.camel@localhost>
Date:	Tue, 04 Dec 2007 09:21:03 -0800
From:	Joe Perches <joe@...ches.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [NETLINK]: af_netlink.c checkpatch cleanups

On Tue, 2007-12-04 at 09:07 +0100, Patrick McHardy wrote:
> [NETLINK]: af_netlink.c checkpatch cleanups
> -static __inline__ void
> +static inline void
>  netlink_lock_table(void)
>  {
>  	/* read_lock() synchronizes us to netlink_table_grab */
> @@ -208,14 +208,15 @@ netlink_lock_table(void)
>  	read_unlock(&nl_table_lock);
>  }
>  
> -static __inline__ void
> +static inline void
>  netlink_unlock_table(void)
>  {
>  	if (atomic_dec_and_test(&nl_table_users))
>  		wake_up(&nl_table_wait);
>  }
>  
> -static __inline__ struct sock *netlink_lookup(struct net *net, int protocol, u32 pid)
> +static inline struct sock *netlink_lookup(struct net *net, int protocol,
> +					  u32 pid)

netlink_lock_table and netlink_unlock_table are the only
function definitions in this patch that have newlines between
function type and function name.

Perhaps checkpatch should warn on newlines between function type
and function names.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html