netdev - Re: cassini driver skb->truesize bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071205173056.GA19264@sch.bme.hu>
Date:	Wed, 5 Dec 2007 18:30:57 +0100
From:	KOVACS Krisztian <hidden@....bme.hu>
To:	Balazs Scheidler <bazsi@...abit.hu>
Cc:	panther@...abit.hu, netdev@...r.kernel.org
Subject: Re: cassini driver skb->truesize bug

Hi,

On Wed, Dec 05, 2007 at 11:23:46AM +0100, Balazs Scheidler wrote:
> Some more investigation revealed that the cassini driver leaks the data
> portion of all RXed packets, this makes the driver completely unusable.
> 
> We've tested the following combinations:
>  * 2.6.17 (patched, but no cassini related patches)
>  * 2.6.22 Ubuntu Gutsy.
> 
> It still worked in 2.6.12 where we originally backported the driver from
> 2.6.14.
> 
> The sk_buff count in slabinfo stays normal, so the skbs are properly
> freed. I'm suspicious about all this cas_page_t wrappers.

Commit fa4f0774d7c6cccb4d1fda76b91dd8eddcb2dd6a?

I don't really see how the buffer count for a page used as a fragment gets
decreased when the skb is freed.

-- 
KOVACS Krisztian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html