netdev - Re: [PATCH 3/3] [UDP]: Only increment counter on first peek/recv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071205.015409.116581624.davem@davemloft.net>
Date:	Wed, 05 Dec 2007 01:54:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] [UDP]: Only increment counter on first peek/recv

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 5 Dec 2007 00:03:10 +1100

> [UDP]: Only increment counter on first peek/recv
> 
> The previous move of the the UDP inDatagrams counter caused each
> peek of the same packet to be counted separately.  This may be
> undesirable.
> 
> This patch fixes this by adding a bit to sk_buff to record whether
> this packet has already been seen through skb_recv_datagram.  We
> then only increment the counter when the packet is seen for the
> first time.
> 
> The only dodgy part is the fact that skb_recv_datagram doesn't have
> a good way of returning this new bit of information.  So I've added
> a new function __skb_recv_datagram that does return this and made
> skb_recv_datagram a wrapper around it.
> 
> The plan is to eventually replace all uses of skb_recv_datagram with
> this new function at which time it can be renamed its proper name.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks for fixing all of this Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html