netdev - Re: [PATCH 3/3] [TCP]: NAGLE_PUSH seems to be a wrong way around

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071205.022634.114614917.davem@davemloft.net>
Date:	Wed, 05 Dec 2007 02:26:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] [TCP]: NAGLE_PUSH seems to be a wrong way around

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Tue,  4 Dec 2007 18:48:50 +0200

> The comment in tcp_nagle_test suggests that. This bug is very
> very old, even 2.4.0 seems to have it.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Wow, I can't believed I missed this during the TSO output
path rewrite.

I will have to double check the history, because I stated
at these conditionals many times during that work and I
wonder if I inverted a "!" somewhere along the line.

Thanks for the fix, applied!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html