netdev - Re: [PATCH 1/8] bonding: Remove trailing NULs from sysfs interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4759A6C5.7040701@pobox.com>
Date:	Fri, 07 Dec 2007 15:02:13 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Jay Vosburgh <fubar@...ibm.com>
CC:	netdev@...r.kernel.org, Wagner Ferenc <wferi@...f.hu>
Subject: Re: [PATCH 1/8] bonding: Remove trailing NULs from sysfs interface.

Jay Vosburgh wrote:
> From: Wagner Ferenc <wferi@...f.hu>
> 
> From: Wagner Ferenc <wferi@...f.hu>
> 
> Also remove trailing spaces from multivalued files.
> 
> This fixes output like for example:
> 
> $ od -c /sys/class/net/bond0/bonding/slaves
> 0000000   e   t   h   -   l   e   f   t       e   t   h   -   r   i   g
> 0000020   h   t      \n  \0
> 0000025
> 
> It mostly entails deleting '+1'-s after sprintf() calls: the return value
> of sprintf is the number of characters printed, without the closing NUL,
> ie. exactly what the sysfs interface requires.  The three multivalue
> cases are different, because they also have to swallow back a trailing
> space.
> 
> Signed-off-by: Ferenc Wagner <wferi@...f.hu>
> Acked-by: Jay Vosburgh <fubar@...ibm.com>
> ---
>  drivers/net/bonding/bond_sysfs.c |   66 +++++++++++++++++--------------------
>  1 files changed, 30 insertions(+), 36 deletions(-)

applied 1-8 to #upstream-fixes

Your script is duplicating the "From: " line twice


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html