netdev - Re: [PATCH 1/2] e1000: fix memcpy in e1000_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4759A705.5070309@garzik.org>
Date:	Fri, 07 Dec 2007 15:03:17 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, 12o3l@...cali.nl
Subject: Re: [PATCH 1/2] e1000: fix memcpy  in e1000_get_strings

Auke Kok wrote:
> From: Roel Kluin <12o3l@...cali.nl>
> 
> drivers/net/e1000/e1000_ethtool.c:113:
> #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN
> 
> drivers/net/e1000e/ethtool.c:106:
> #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN
> 
> E1000_TEST_LEN*ETH_GSTRING_LEN will expand to
> sizeof(e1000_gstrings_test) / (ETH_GSTRING_LEN * ETH_GSTRING_LEN)
> 
> A lack of parentheses around defines causes unexpected results due to
> operator precedences.
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> ---
> 
>  drivers/net/e1000/e1000_ethtool.c |    2 +-
>  drivers/net/e1000e/ethtool.c      |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

applied 1-2 to #upstream-fixes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html