netdev - Re: [PATCH][IPV4] Swap the ifa allocation with the"ipv4_devconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071207.235557.163989906.davem@davemloft.net>
Date:	Fri, 07 Dec 2007 23:55:57 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org,
	devel@...nvz.org
Subject: Re: [PATCH][IPV4] Swap the ifa allocation with
 the"ipv4_devconf_setall" call

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Fri, 07 Dec 2007 12:22:57 +0300

> According to Herbert, the ipv4_devconf_setall should be called
> only when the ifa is added to the device. However, failed 
> ifa allocation may bring things into inconsistent state.
> 
> Move the call to ipv4_devconf_setall after the ifa allocation.
> 
> Fits both net-2.6 (with offsets) and net-2.6.25 (cleanly).
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Applied to net-2.6, thanks Pavel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html