netdev - Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs vlan_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Dec 2007 02:41:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	xemul@...nvz.org, netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH] vlan: fix potential race in vlan_cleanup_module vs
 vlan_ioctl_handler

From: Patrick McHardy <kaber@...sh.net>
Date: Tue, 11 Dec 2007 11:38:38 +0100

> Pavel Emelyanov wrote:
> > AFAIS there's a tiny race window between these two
> > calls - after rtnl unregistered all the vlans, but 
> > the ioctl handler isn't set to NULL yet, user can 
> > manage to call this ioctl and create one vlan device, 
> > and that this function will later BUG_ON seeing 
> > non-emply hashes.
> 
> Indeed, I can't see anything preventing this.
> 
> > I think, that we must first close the vlan ioctl
> > and only after this remove all the vlans with the
> > vlan_netlink_fini() call.
> 
> That looks correct, thanks Pavel. Dave, please apply.

Applied to net-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html