netdev - Re: [TCP]: fack_counts more fixes (the previous ones were incomplete)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071211.041507.261395652.davem@davemloft.net>
Date:	Tue, 11 Dec 2007 04:15:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org, reuben-linuxkernel@...b.net,
	akpm@...ux-foundation.org
Subject: Re: [TCP]: fack_counts more fixes (the previous ones were
 incomplete)

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Tue, 11 Dec 2007 13:43:24 +0200 (EET)

> [PATCH] [TCP]: fack_counts more fixes (the previous ones were incomplete)
> 
> 1) Prev NULL check should also dereference
> 
> 2) The loop reorganization did make things only slightly better,
>    just changing the same not-updated problem to occur in
>    another scenario. And I also noticed that in worst case it
>    would be an infinite loop (could do that also before the
>    change), but it required losses in the same window when TCP
>    runs out new data. Now check really against the list heads
>    rather than a valid skb which should still be processed.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Applied, thanks Ilpo.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html