netdev - Re: [IPSEC]: Fix potential dst leak in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071211.044016.218495218.davem@davemloft.net>
Date:	Tue, 11 Dec 2007 04:40:16 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [IPSEC]: Fix potential dst leak in xfrm_lookup

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 11 Dec 2007 20:07:29 +0800

> [IPSEC]: Fix potential dst leak in xfrm_lookup
> 
> If we get an error during the actual policy lookup we don't free the
> original dst while the caller expects us to always free the original
> dst in case of error.
> 
> This patch fixes that.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Sigh, thanks for fixing this.  Applied to net-2.6 and I'll toss it
over to -stable too.

I bet the __xfrm_lookup() callers could stand a major audit, with the
special -EREMOTE logic I bet there are non-EREMOTE code paths there
that don't handle the dst ref semantics properly.

This is a very error prone interface, both at the implementation
and in the callers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html