netdev - Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071211151336.GA1248@infradead.org>
Date:	Tue, 11 Dec 2007 15:13:36 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Ilpo J?rvinen <ilpo.jarvinen@...sinki.fi>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] [TCP]: Include __tcp_reset_fack_counts to non-__
	version

On Tue, Dec 11, 2007 at 01:50:39PM +0200, Ilpo J?rvinen wrote:
> +		BUG_ON((prev != NULL) && !tcp_skb_adjacent(sk, prev, skb[queue]));
> +
> +		tcp_for_write_queue_from(skb[queue], sk, queue) {
> +			if ((prev != NULL) && !tcp_skb_adjacent(sk, prev, skb[queue]))
> +				break;
> +
> +			if (!before(TCP_SKB_CB(skb[queue])->seq, tcp_sk(sk)->snd_nxt) ||
> +			    TCP_SKB_CB(skb[queue])->fack_count == fc)
> +				return;

There's quite a few overflows of the normal 80 char limit here.  Because
you're current style is a little on the verbose side that's trivially
fixable, though:

		BUG_ON(prev && !tcp_skb_adjacent(sk, prev, skb[queue]));

		tcp_for_write_queue_from(skb[queue], sk, queue) {
			if (prev && !tcp_skb_adjacent(sk, prev, skb[queue]))
				break;

			if (!before(TCP_SKB_CB(skb[queue])->seq,
					       tcp_sk(sk)->snd_nxt) ||
			    TCP_SKB_CB(skb[queue])->fack_count == fc)
				return;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html