lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 12 Dec 2007 21:01:58 +0100
From:	Lennert Buytenhek <>
To:	Wang Chen <>
Cc:	"David S. Miller" <>,
	Jeff Garzik <>,
Subject: Re: [PATCH 3/4] ixp2000: rtnl_lock out of loop will be faster

On Wed, Dec 12, 2007 at 04:48:28PM +0800, Wang Chen wrote:

> [PATCH 3/4] [NETDEV] ixp2000: rtnl_lock out of loop will be faster
> Before this patch, it gets and releases the lock at each
> iteration of the loop. Changing unregister_netdev to
> unregister_netdevice and locking outside of the loop will
> be faster for this approach.

Since the number of net devices is typically either 2 or 3 (depending
on the specific model card you're using), and this is not in any kind
of hot path at all, I don't see a whole lot of benefit of acquiring
the RTNL separately.  Besides, I'm slightly worried about putting
knowledge of the RTNL into the driver directly.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists