[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 12 Dec 2007 10:35:56 +0800
From: Wang Chen <wangchen@...fujitsu.com>
To: Jeff Garzik <jgarzik@...ox.com>
CC: Krzysztof Halasa <khc@...waw.pl>, netdev@...r.kernel.org,
"David S. Miller" <davem@...emloft.net>
Subject: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice
[PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice
Since the caller and the upper caller doesn't hod the rtnl semaphore.
We should use unregister_netdev instead of unregister_netdevice.
Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
---
hdlc_fr.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.24.rc5.org/drivers/net/wan/hdlc_fr.c 2007-10-10 04:31:38.000000000 +0800
+++ linux-2.6.24.rc5/drivers/net/wan/hdlc_fr.c 2007-12-12 10:25:13.000000000 +0800
@@ -1177,7 +1177,7 @@ static int fr_del_pvc(hdlc_device *hdlc,
if (dev->flags & IFF_UP)
return -EBUSY; /* PVC in use */
- unregister_netdevice(dev); /* the destructor will free_netdev(dev) */
+ unregister_netdev(dev); /* the destructor will free_netdev(dev) */
*get_dev_p(pvc, type) = NULL;
if (!pvc_is_used(pvc)) {
@@ -1202,10 +1202,10 @@ static void fr_destroy(struct net_device
pvc_device *next = pvc->next;
/* destructors will free_netdev() main and ether */
if (pvc->main)
- unregister_netdevice(pvc->main);
+ unregister_netdev(pvc->main);
if (pvc->ether)
- unregister_netdevice(pvc->ether);
+ unregister_netdev(pvc->ether);
kfree(pvc);
pvc = next;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists