netdev - Re: [PATCH] iproute2: support dotted-quad netmask notation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2007 12:55:13 +0100
From:	Andreas Henriksson <andreas@...al.se>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: support dotted-quad netmask notation.

On Tue, Dec 11, 2007 at 05:14:06PM -0800, Stephen Hemminger wrote:
> On Sun, 09 Dec 2007 18:10:22 +0100
> Andreas Henriksson <andreas@...al.se> wrote:
> > I think both previous patches where broken on big-endian platforms.
> > Here's an updated patch again. I'm very sorry for the inconvenience!
[...]
> > +		*val=0;
> > +		for (mask = ntohl(addr.data[0]); mask; mask <<= 1)
> > +			(*val)++;
[...]
> 
> applied
> 

Just to make sure.... It looks on git.kernel.org like you applied the wrong
patch. (Maybe you just haven't pushed out the latest changes there yet.)
Please double-check that you actually applied the latest version (which is
the one in the mail you replied "applied" to, important part quoted above). 

Additionally, there's still a couple of trivial patches pending in
the "patches" branch of 
git://git.debian.org/git/collab-maint/pkg-iproute.git

Please see the original thread[1], where Patrick McHarding had some concerns
about one of the patches. It's exactly the same changes you made in commit
660818498d0f5a3f52c05355a3e82c23f670fcc1 [2] though, so I don't really see the
problem. I have an additional patch[3] available, that makes MAX_ROUNDS
configurable which Patrick requested.

Please comment on the way forward there....

[1]: http://www.spinics.net/lists/netdev/msg44800.html
[2]: Where the comment seems to be wrong about "Limit ip route flush...",
     since it's actually "ip neigh flush" that's being modified.
[3]: I have a slightly updated patch, but it's basically the same as
     http://www.spinics.net/lists/netdev/msg45080.html
	 Will send updated version if the patches it's based on goes in.

-- 
Regards,
Andreas Henriksson
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html