lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Thu, 13 Dec 2007 19:18:38 +0000
From:	Robert Stonehouse <>
Subject: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller
 - 2nd try

This is a resubmission of a new driver for Solarflare network controllers.

The driver supports many types of PHY (10Gbase-T, XFP, CX4) on five
different 10G reference designs and one 1G NIC ref design.

The previous thread was:
  "[PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller"

Since the 1st patch we have addressed the review comments we received
 - removed usage of __LINK_STATE_START as unnecessary with latest NAPI
 - cleaned up many checkpatch violations
 - used the generic drv_* logging
   (macros were kept so that the network device name can be printed
consistently in all messaging but these can be dissolved if necessary)
 - Reduced over-use of docbook type comments
 - replaced uintN_t with uN types
 - merged some small headers to reduce the file count

It is still quite a large driver at ~25k LOC. The main body of the driver
is within efx.c, falcon.c, tx.c and rx.c if this helps direct review effort.

We welcome more review comments and will try and respond to them more
quickly than last time.

The patch (against net-2.6.25) is at:

The new files may also be downloaded as a tarball:

And for verification there is:


Rob Stonehouse
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists