lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Dec 2007 11:13:44 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: davem@...emloft.net (David Miller) Cc: wangchen@...fujitsu.com, jgarzik@...ox.com, khc@...waw.pl, netdev@...r.kernel.org Subject: Re: [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice David Miller <davem@...emloft.net> wrote: > From: Wang Chen <wangchen@...fujitsu.com> > Date: Wed, 12 Dec 2007 10:35:56 +0800 > >> [PATCH] HDLC driver: use unregister_netdev instead of unregister_netdevice > > Applied, thanks for finding and fixing this bug. Let's see who else is doing this: [NET]: Check RTNL status in unregister_netdevice The caller must hold the RTNL so let's check it in unregister_netdevice. Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> diff --git a/net/core/dev.c b/net/core/dev.c index 06615df..b254e52 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3967,6 +3967,8 @@ void synchronize_net(void) void unregister_netdevice(struct net_device *dev) { + ASSERT_RTNL(); + rollback_registered(dev); /* Finish processing unregister after unlock */ net_set_todo(dev); Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists