netdev - Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071213.064955.91784038.davem@davemloft.net>
Date:	Thu, 13 Dec 2007 06:49:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	adobriyan@...ru
Cc:	den@...nvz.org, containers@...ts.osdl.org, netdev@...r.kernel.org,
	devel@...nvz.org
Subject: Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in
 fib_rules.h.

From: Alexey Dobriyan <adobriyan@...ru>
Date: Thu, 13 Dec 2007 17:47:07 +0300

> On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> > There are to many spaces between type and function name in the declaration
> > of fib rules manipulation routines. Eat them and save a couple of lines.
> 
> If this patch is going in, it would be nice to get rid of "extern" as
> well.

The convention in the networking headers is to use extern, and
this is pretty consistently done across the board.

If we are going to do this, which I personally see no reason
for, we should do it across the whole networking.

Consistency is much more important than whatever reason you
could come up with to get rid of the 'extern'.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html