[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4761494C.4000202@sw.ru>
Date: Thu, 13 Dec 2007 18:01:32 +0300
From: "Denis V. Lunev" <den@...ru>
To: David Miller <davem@...emloft.net>
CC: den@...nvz.org, containers@...ts.osdl.org, devel@...nvz.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
David Miller wrote:
> From: "Denis V. Lunev" <den@...nvz.org>
> Date: Thu, 13 Dec 2007 17:18:42 +0300
>
>> There are to many spaces between type and function name in the declaration
>> of fib rules manipulation routines. Eat them and save a couple of lines.
>>
>> Signed-off-by: Denis V. Lunev <den@...nvz.org>
>
> This is just noise and serves nothing other than to invite potential
> patch conflicts which makes development harder.
>
> If you happened to be changing these for other reasons, I'd say OK,
> but not like this.
>
I will add parameter to these calls. The line will be too long after
that. I'd like to separate sense changes from, you perfectly correct,
useless changes :(
Could you still apply it, or I will need to send fully functional set to
you including this?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists