lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071213015856.GA32668@gondor.apana.org.au> Date: Thu, 13 Dec 2007 09:58:56 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Andrew Morton <akpm@...ux-foundation.org> Cc: David Miller <davem@...emloft.net>, ilpo.jarvinen@...sinki.fi, netdev@...r.kernel.org Subject: [IPSEC]: Fix reversed ICMP6 policy check On Wed, Dec 12, 2007 at 05:39:51PM -0800, Andrew Morton wrote: > > Here's the screen-shot (actually more like a reen-hot): > http://userweb.kernel.org/~akpm/pc121694.jpg > > I'm awaiting a reoccurrence with the screen in 50-row mode. Sorry, I didn't test IPv6. [IPSEC]: Fix reversed ICMP6 policy check The policy check I added for ICMP on IPv6 is reversed. This patch fixes that. It also adds an skb->sp check so that unprotected packets that fail the policy check do not crash the machine. Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 4e3bfcd..132e879 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -978,7 +978,7 @@ int icmp_rcv(struct sk_buff *skb) struct icmphdr *icmph; struct rtable *rt = (struct rtable *)skb->dst; - if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb) && + if (!xfrm4_policy_check(NULL, XFRM_POLICY_IN, skb) && skb->sp && skb->sp->xvec[skb->sp->len - 1]->props.flags & XFRM_STATE_ICMP) { int nh; diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 478ee77..64d78c9 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6/icmp.c @@ -646,7 +646,7 @@ static int icmpv6_rcv(struct sk_buff *skb) struct icmp6hdr *hdr; int type; - if (xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb) && + if (!xfrm6_policy_check(NULL, XFRM_POLICY_IN, skb) && skb->sp && skb->sp->xvec[skb->sp->len - 1]->props.flags & XFRM_STATE_ICMP) { int nh; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists