netdev - Re: [patch 2/4] net: use mutex_is_locked() for ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071214.113055.134616186.davem@davemloft.net>
Date:	Fri, 14 Dec 2007 11:30:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org
Subject: Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

From: akpm@...ux-foundation.org
Date: Thu, 13 Dec 2007 16:02:36 -0800

> From: Andrew Morton <akpm@...ux-foundation.org>
> 
> ASSERT_RTNL() uses mutex_trylock(), but it's better to use mutex_is_locked().
> 
> Make that change, and remove rtnl_trylock() altogether.
> 
> (not tested yet!)
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

NACK, as explained please remove this until the replacement
doesn't remove valid checks which are done currently.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html