netdev - Re: Badness at net/core/dev.c:2199

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071216184637.GA20871@2ka.mipt.ru>
Date:	Sun, 16 Dec 2007 21:46:37 +0300
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Meelis Roos <mroos@...ux.ee>, netdev@...r.kernel.org
Subject: Re: Badness at net/core/dev.c:2199

On Sun, Dec 16, 2007 at 10:33:40AM -0800, Stephen Hemminger (shemminger@...ux-foundation.org) wrote:
> > index 3653314..9e0e97a 100644
> > --- a/drivers/net/tulip/interrupt.c
> > +++ b/drivers/net/tulip/interrupt.c
> > @@ -151,8 +151,9 @@ int tulip_poll(struct napi_struct *napi, int budget)
> >                         if (tulip_debug > 5)
> >                                 printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
> >                                        dev->name, entry, status);
> > -		       if (work_done++ >= budget)
> > +		       if (work_done >= budget)
> >                                 goto not_done;
> > +		       work_done++;
> >  
> >                         if ((status & 0x38008300) != 0x0300) {
> >                                 if ((status & 0x38000300) != 0x0300) {
> > 
> > 
> 
> I already sendout a correct patch last week. It should pre-increment.

That will work too.
Thanks Stephen.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html