netdev - Re: [RFT] tehuti: napi fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071216.133833.105913775.davem@davemloft.net>
Date:	Sun, 16 Dec 2007 13:38:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	joonwpark81@...il.com, netdev@...r.kernel.org, jgarzik@...ox.com,
	baum@...utinetworks.net, andy@...yhouse.net
Subject: Re: [RFT] tehuti: napi fix

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Wed, 12 Dec 2007 13:58:52 -0800

> This should fix the tehuti napi fence post problems by getting
> rid of priv->napi_stop, and setting weight to 32 (like other 10G).
> 
> Also, used the wierd entry/exit macro's like rest of driver.

It fixes the fench-post problem, but like the comments you
removed explain:

> -		/* from time to time we exit to let NAPI layer release
> -		 * device lock and allow waiting tasks (eg rmmod) to advance) */
> -		priv->napi_stop = 0;
> -

We now hang on rmmod during constant packet load.

This change just trades one bug for another, we have to
get the device close issue sorted out before we can go
around removing these things.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html