[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1197931361.27386.67.camel@localhost>
Date: Mon, 17 Dec 2007 14:42:41 -0800
From: Joe Perches <joe@...ches.com>
To: Jan Engelhardt <jengelh@...putergmbh.de>
Cc: netdev@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-2.6.25 1/8] Create ipv4_is_<type>(__be32 addr)
functions
On Mon, 2007-12-17 at 23:37 +0100, Jan Engelhardt wrote:
> >+static inline bool ipv4_is_loopback(__be32 addr)
> >+{
> >+ return (addr & htonl(0xff000000)) == htonl(0x7f000000);
> >+}
> >+
> Can we use __constant_htonl()?
I believe the generated code is the same.
> >+static inline bool ipv4_is_private_10(__be32 addr)
> >+{
> >+ return (addr & htonl(0xff000000)) == htonl(0x0a000000);
> >+}
>
> What are these functions needed for, even? There does not seem to be
> any code (at least in davem's net-2.6.25:net/ipv4/, where I dared to grep)
> that uses them.
include/net/addrconf.h
net/sctp/protocol.c
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists