netdev - Re: [PATCH] endianness annotations and fixes for olympic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Dec 2007 18:15:50 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Al Viro <viro@....linux.org.uk>
CC:	mikep@...uxtr.net, netdev@...r.kernel.org, kaaker@...cade.com
Subject: Re: [PATCH] endianness annotations and fixes for olympic

Al Viro wrote:
> 	* missing braces in !readl(...) & ...
> 	* trivial endianness annotations
> 	* in olympic_arb_cmd() the loop collecting fragments of
> packet is b0rken on big-endian - we have
> 	(next_ptr && (buf_ptr=olympic_priv->olympic_lap + ntohs(next_ptr)))
> as condition and it should have swab16(), not ntohs() - it's host-endian
> byteswapped, not big-endian.  So if we get more than one fragment on big-endian
> host, we get screwed.
> 	This ntohs() got missed back when the rest of those had been switched
> to swab16() in 2.4.0-test2-pre1 - at a guess, nobody had hit fragmented
> packets during the testing of PPC fixes.
> 
> PS: Ken Aaker cc'd on assumption that he is the same guy who'd done the
> original set of PPC fixes in olympic
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

applied #upstream


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html