lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 17 Dec 2007 15:31:33 +0800
From:	Herbert Xu <>
To:	Jarek Poplawski <>
Cc:	Andrew Morton <>,
	David Miller <>,
Subject: Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote:
> Btw. #2: David Miller gave this example of ASSERT_RTNL use:
> 	page = alloc_page(GFP_KERNEL);
> But isn't there a debugging duplication: it seems alloc_page() is used
> in so many places and this check for GFP is/should_be there already?

On some paths this may be buried a conditional.  Also if you
replace it with a mutex_is_locked without the may_sleep it won't
catch the case that started all this, namely the promiscuous path.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists