netdev - Re: [patch 2/4] net: use mutex_is_locked() for ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071217012632.GA8475@gondor.apana.org.au>
Date:	Mon, 17 Dec 2007 09:26:32 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

On Sun, Dec 16, 2007 at 07:06:41PM +0100, Jarek Poplawski wrote:
>
> It seemed to exist a few days ago:
> http://kerneltrap.org/mailarchive/linux-netdev/2007/12/4/473123
> 
> Btw., I don't know which of the patches: Eric's or yours will be chosen,
> but, IMHO, there is no reason to remove rtnl_trylock(), which can be still
> useful, just like mutex_trylock() is.

Doh! Andrew was too convincing :) I misread the grep result on
in_interrupt.  Of course that function returns true if we're
either in an IRQ handler or have BH off.

I retract what I've said in this thread and continue to oppose
this change without a might_sleep.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html