lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <11979809963141-git-send-email-panther@balabit.hu> Date: Tue, 18 Dec 2007 13:29:54 +0100 From: Laszlo Attila Toth <panther@...abit.hu> To: David Miller <davem@...emloft.net>, Patrick McHardy <kaber@...sh.net> Cc: Jarek Poplawski <jarkao2@...pl>, netdev@...r.kernel.org, netfilter-devel@...r.kernel.org, Laszlo Attila Toth <panther@...abit.hu> Subject: [PATCHv7 1/5][RESEND] Remove unnecessary locks from rtnetlink The do_setlink() function is protected by rtnl, additional locks are unnecessary. and the set_operstate() function is called from protected parts. Locks removed from both functions. The set_operstate() is also called from rtnl_create_link() and from no other places. In rtnl_create_link() none of the changes is protected by set_lock_bh() except inside set_operstate(), different locking scheme is not necessary for the operstate. Signed-off-by: Laszlo Attila Toth <panther@...abit.hu> --- net/core/rtnetlink.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 4a07e83..f95c6c5 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -562,9 +562,7 @@ static void set_operstate(struct net_device *dev, unsigned char transition) } if (dev->operstate != operstate) { - write_lock_bh(&dev_base_lock); dev->operstate = operstate; - write_unlock_bh(&dev_base_lock); netdev_state_change(dev); } } @@ -879,9 +877,7 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm, set_operstate(dev, nla_get_u8(tb[IFLA_OPERSTATE])); if (tb[IFLA_LINKMODE]) { - write_lock_bh(&dev_base_lock); dev->link_mode = nla_get_u8(tb[IFLA_LINKMODE]); - write_unlock_bh(&dev_base_lock); } err = 0; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists