netdev - Re: [PATCH] NET: Fix function put_cmsg() which may cause usr application memory overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071220.143956.103295054.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 14:39:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yjwei@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET: Fix function put_cmsg() which may cause usr
 application memory overflow

From: Wei Yongjun <yjwei@...fujitsu.com>
Date: Tue, 18 Dec 2007 15:19:09 +0900

> When used function put_cmsg() to copy kernel information to user 
> application memory, if the memory length given by user application is 
> not enough, by the bad length calculate of msg.msg_controllen, 
> put_cmsg() function may cause the msg.msg_controllen to be a large 
> value, such as 0xFFFFFFF0, so the following put_cmsg() can also write 
> data to usr application memory even usr has no valid memory to store 
> this. This may cause usr application memory overflow.
 ...
> The same promble exists in put_cmsg_compat(). This patch can fix this 
> problem.
> 
> Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com>

Thank you for fixing this bug, patch applied.

put_cmsg() is a confusing function, it takes a while to understand
what it is trying to accomplish.  And this explains why this bug
lived for so long.

Each CMSG entry has to be aligned, but put_cmsg() will allow to
put the full final message into the CMSG area if there is enough
room to fit the message without the added alignment.

So, with Wei's fix, we now have:

	int cmlen = CMSG_LEN(len);
 ...
	if (msg->msg_controllen < cmlen) {
		msg->msg_flags |= MSG_CTRUNC;
		cmlen = msg->msg_controllen;
	}
 ...
	if (copy_to_user(cm, &cmhdr, sizeof cmhdr))
		goto out;
	if (copy_to_user(CMSG_DATA(cm), data, cmlen - sizeof(struct cmsghdr)))
		goto out;
	cmlen = CMSG_SPACE(len);
	if (msg->msg_controllen < cmlen)
		cmlen = msg->msg_controllen;
	msg->msg_control += cmlen;
	msg->msg_controllen -= cmlen;
 ...

which I think finally implements the intended behavior
accurately.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html