netdev - Re: [PATCH] drivers/net/niu: Support for Marvell PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071220.152503.263532731.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 15:25:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mlindner@...vell.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/niu: Support for Marvell PHY

From: Mirko Lindner <mlindner@...vell.com>
Date: Tue, 18 Dec 2007 17:03:58 +0100

> +static int xcvr_init_10g_mrvl88x2011(struct niu *np)
> +{
> +	int err;
> +
> +	/* Set LED functions */
> +	mrvl88x2011_led_blink_rate(np, 2);
> +	mrvl88x2011_act_led(np, 0);	/* led activity */
> +
> +	err = mdio_read(np, np->phy_addr, 3, 0x8300);
> +	if (err < 0) {
> +		return(err);
> +	}
> +
> +	err |= 0x0001;
> +
> +	err = mdio_write(np, np->phy_addr, 3, 0x8300, err);
> +	if (err < 0) {
> +		return(err);
> +	}
> +
> +	/* Enable PMD */
> +	err = mdio_write(np, np->phy_addr, 1, 0x0009, 0);
> +	
> +	return (err);
> +}
> +

This code doesn't handle putting the PHY into loopback more etc. like
the BCM8704 chip initialization does.

Please also fully document the registers using defines in the niu.h
header file as is already done for the BCM8704 registers.  Magic
constants are not allowed.

I'd like this Marvell PHY chip to be documented so that, just like the
BCM8704, someone can look at the driver and understand how the chip
works and thus make bug fixes and changes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html