netdev - Re: [PATCH][IPV4] ip_gre: set mac_header correctly in receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071220.001127.23448802.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 00:11:27 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	timo.teras@....fi
Cc:	kuznet@....inr.ac.ru, netdev@...r.kernel.org
Subject: Re: [PATCH][IPV4] ip_gre: set mac_header correctly in receive path

From: Timo_Teräs <timo.teras@....fi>
Date: Wed, 19 Dec 2007 20:10:41 +0200

> From: Timo Teras <timo.teras@....fi>
> 
> mac_header update in ipgre_recv() was incorrectly changed to
> skb_reset_mac_header() when it was introduced.
> 
> Signed-off-by: Timo Teras <timo.teras@....fi>

Patch applied, thanks.

> ---
> This replaces my earlier patch titled "ip_gre: use skb->{mac,
> network}_header consistently". Apparently I hadn't done my homework how
> to use *_header correctly. And I should have done a bit more testing to
> figure out the previous patch does not work.
> 
> But the main problem was the receive path in the first place, and this
> patch fixes it.
> 
> The bug was introduced in commit 459a98ed881802dee55897441bc7f77af614368e.
> There might be other similar incorrect replaces.

That commit has two other identical bad conversions, I'll
fix them up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html