netdev - Re: [patch 1/2][NETNS] net: Modify the neighbour table code so it handles multiple network namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071220.154022.13738739.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 15:40:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	netdev@...r.kernel.org, den@...nvz.org, benjamin.thery@...l.net,
	ebiederm@...ssion.com
Subject: Re: [patch 1/2][NETNS] net: Modify the neighbour table code so it
 handles multiple network namespaces

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Wed, 19 Dec 2007 15:55:45 +0100

> -struct neigh_seq_state {
> +struct neigh_seq_state
> +{

Please don't make coding style change like this.

The accepted convention is:

struct NAME {
	...
};

I know the other structs in that header file use the lousy:

struct NAME
{
};

format, but that doesn't make it right and we gain nothing
by taking a step backwards instead of fixing all the instances
in that header file over to the correct style.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html