lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Dec 2007 23:44:55 -0800 (PST) From: David Miller <davem@...emloft.net> To: herbert@...dor.apana.org.au Cc: netdev@...r.kernel.org Subject: Re: [IPSEC]: Avoid undefined shift operation when testing algorithm ID From: Herbert Xu <herbert@...dor.apana.org.au> Date: Thu, 20 Dec 2007 12:29:37 +0800 > [IPSEC]: Avoid undefined shift operation when testing algorithm ID > > The aalgos/ealgos fields are only 32 bits wide. However, af_key tries > to test them with the expression 1 << id where id can be as large as > 253. This produces different behaviour on different architectures. > > The following patch explicitly checks whether ID is greater than 31 > and fails the check if that's the case. > > We cannot easily extend the mask to be longer than 32 bits due to > exposure to user-space. Besides, this whole interface is obsolete > anyway in favour of the xfrm_user interface which doesn't use this > bit mask in templates (well not within the kernel anyway). > > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au> Thanks for fixing this bug, patch applied! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists