netdev - Re: [TCP] tcp_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071221122316.GU6264@ghostprotocols.net>
Date:	Fri, 21 Dec 2007 10:23:16 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [TCP] tcp_write_timeout.c cleanup

Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu:
> Before submiting a patch to change a divide to a right shift, I felt
> necessary to create a helper function tcp_mtu_probing() to reduce length of 
> lines exceeding 100 chars in tcp_write_timeout().
>
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
>

> diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
> index d8970ec..8f14808 100644
> --- a/net/ipv4/tcp_timer.c
> +++ b/net/ipv4/tcp_timer.c
> @@ -114,13 +114,31 @@ static int tcp_orphan_retries(struct sock *sk, int alive)
>  	return retries;
>  }
>  
> +static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct sock *sk)
> +{
> +	int mss;
-       int mss;
		
> +
> +	/* Black hole detection */
> +	if (sysctl_tcp_mtu_probing) {
> +		if (!icsk->icsk_mtup.enabled) {
> +			icsk->icsk_mtup.enabled = 1;
> +			tcp_sync_mss(sk, icsk->icsk_pmtu_cookie);
> +		} else {
> +			struct tcp_sock *tp = tcp_sk(sk);
+			int mss;
> +			mss = tcp_mtu_to_mss(sk, icsk->icsk_mtup.search_low)/2;
> +			mss = min(sysctl_tcp_base_mss, mss);
> +			mss = max(mss, 68 - tp->tcp_header_len);
> +			icsk->icsk_mtup.search_low = tcp_mss_to_mtu(sk, mss);
> +			tcp_sync_mss(sk, icsk->icsk_pmtu_cookie);
> +		}
> +	}
> +}

:-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html