netdev - Re: [PATCH] [IPROUTE]: A workaround to make larger rto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d72b7ace0712210549u51043bf8k585fd70e1ded7d8a@mail.gmail.com>
Date:	Fri, 21 Dec 2007 22:49:59 +0900
From:	"Satoru SATOH" <satoru.satoh@...il.com>
To:	"YOSHIFUJI Hideaki / 吉藤英明" 
	<yoshfuji@...ux-ipv6.org>
Cc:	shemminger@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

I agree.

I mistakenly thought hz in that context must be larger than 1000..
As it's uncertain, your's looks much simpler and better.

(btw, the lines "else .... div = 1" is not needed, is it?)

Thanks,
Satoru SATOH

2007/12/21, YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@...ux-ipv6.org>:
(snip)
> Why don't you simply use unsigned long long (or maybe uint64_t) here?
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
>
> ---
> diff --git a/ip/iproute.c b/ip/iproute.c
> index f4200ae..db9a3b6 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -509,16 +509,21 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>                             i != RTAX_RTO_MIN)
>                                 fprintf(fp, " %u", *(unsigned*)RTA_DATA(mxrta[i]));
>                         else {
> -                               unsigned val = *(unsigned*)RTA_DATA(mxrta[i]);
> +                               unsigned long long val = *(unsigned*)RTA_DATA(mxrta[i]);
> +                               unsigned div = 1;
>
> -                               val *= 1000;
>                                 if (i == RTAX_RTT)
> -                                       val /= 8;
> +                                       div = 8;
>                                 else if (i == RTAX_RTTVAR)
> -                                       val /= 4;
> -                               if (val >= hz)
> -                                       fprintf(fp, " %ums", val/hz);
> +                                       div = 4;
>                                 else
> +                                       div = 1;
> +
> +                               val = val * 1000ULL / div;
> +
> +                               if (val >= hz) {
> +                                       fprintf(fp, " %llums", val/hz);
> +                               } else
>                                         fprintf(fp, " %.2fms", (float)val/hz);
>                         }
>                 }
>
> --yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html