netdev - Re: [XFRM]: Fix outbound statistics.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071221151111.GA2466@gondor.apana.org.au>
Date:	Fri, 21 Dec 2007 23:11:11 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Masahide NAKAMURA <nakam@...ux-ipv6.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	usagi-core@...ux-ipv6.org
Subject: Re: [XFRM]: Fix outbound statistics.

On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote:
>
>  	do {
>  		err = xfrm_state_check_space(x, skb);
> -		if (err)
> +		if (err) {
> +			XFRM_INC_STATS(LINUX_MIB_XFRMOUTERROR);
>  			goto error_nolock;
> +		}
>  
>  		err = x->outer_mode->output(x, skb);
> -		if (err)
> +		if (err) {
> +			XFRM_INC_STATS(LINUX_MIB_XFRMOUTSTATEMODEERROR);

BTW, none of our existing mode output functions actually return
an error.  I noticed that the description for this field is actually
"Transformation mode specific error, e.g. Outer header space is not
enough".  This is slightly misleading as output header space is
checked by xfrm_state_check_space so if there's an error that's
where it'll show up.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html