lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Dec 2007 23:11:11 +0800
From:	Herbert Xu <>
To:	Masahide NAKAMURA <>
Subject: Re: [XFRM]: Fix outbound statistics.

On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote:
>  	do {
>  		err = xfrm_state_check_space(x, skb);
> -		if (err)
> +		if (err) {
>  			goto error_nolock;
> +		}
>  		err = x->outer_mode->output(x, skb);
> -		if (err)
> +		if (err) {

BTW, none of our existing mode output functions actually return
an error.  I noticed that the description for this field is actually
"Transformation mode specific error, e.g. Outer header space is not
enough".  This is slightly misleading as output header space is
checked by xfrm_state_check_space so if there's an error that's
where it'll show up.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists