netdev - Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200712211853.52230.netdev@axxeo.de>
Date:	Fri, 21 Dec 2007 18:53:51 +0100
From:	Ingo Oeser <netdev@...eo.de>
To:	David Miller <davem@...emloft.net>
Cc:	xemul@...nvz.org, netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function

Hi David,

David Miller schrieb:
> "inet_timewait_sock" begins with a "struct sock_common"
> which is where the atomic_t is, and:
> 
> #define tw_refcnt		__tw_common.skc_refcnt
> 
> So you would have to change struct sock_common over to kref, and thus
> the entire networking, in order to make such a change.

Ok, that sounds too much. Many thanks for following up and taking the time
to explain it.
 
> But you would have seen this instantly if you had spent 5 seconds
> looking at how these datastructures are defined.  Instead you choose
> to make me do it and explain it to you instead.

Sorry, just matched the wrong pattern here :-)


Best Regards

Ingo Oeser
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html