netdev - Re: [SOCK] Avoid integer divides where not necessary in include/net/sock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071221.030640.100066714.davem@davemloft.net>
Date:	Fri, 21 Dec 2007 03:06:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [SOCK] Avoid integer divides where not necessary in
 include/net/sock.h

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 21 Dec 2007 11:40:51 +0100

> On Fri, 21 Dec 2007 01:55:43 -0800 (PST)
> David Miller <davem@...emloft.net> wrote:
> 
> Please tell me if you are OK with this solution, or if you prefer
> I change sk_forward_alloc to be unsigned :)

When I was playing with this crap a long time ago I
think I remember that sk->sk_forward_alloc can become
negative in some circumstances.

Or maybe that was just a bug :-)

> Here is the patch handling the change on sk_wmem_queued, sk_sndbuf.
> Keeping small patches may help future bisection anyway...
> 
> [SOCK] Avoid integer divides where not necessary in include/net/sock.h
> 
> Because sk_wmem_queued, sk_sndbuf are signed, a divide per two
> may force compiler to use an integer divide.
> 
> We can instead use a right shift.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

I'll apply this, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html