netdev - Re: [ETH]: Combine format_addr() with print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1198306965.4895.5.camel@localhost>
Date:	Fri, 21 Dec 2007 23:02:45 -0800
From:	Joe Perches <joe@...ches.com>
To:	Michael Chan <mchan@...adcom.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, anilgv@...adcom.com,
	michaelc@...wisc.edu, david.somayajulu@...gic.com
Subject: Re: [ETH]: Combine format_addr() with print_mac().

On Fri, 2007-12-21 at 19:58 -0800, Michael Chan wrote:
> The dev_addr is declared as unsigned char* in struct net_device.  To be
> consistent, can we change print_mac() and MAC_BUF to use unsigned char*?
> They are really the same.

That's fine by me.  I like consistency.
I don't remember why it was u8 and not unsigned char.

> > ssize_t? shouldn't it be size_t?
> I'm just keeping the prototype unchanged as originally defined in net-
> sysfs.c

It's painless to change the prototype.
size_t seems more sensible.

> > Indexing buf by int len is unchecked.
> > That could lead to unintended buffer overruns.
> > Maybe add a buflen argument and use snprintf?
> Again, I kept the semantics the same as the original, but will be happy
> to add a buflen for better checking.

That sounds good.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html